feat(observe): allow disabling function io capture by env var#1196
Merged
feat(observe): allow disabling function io capture by env var#1196
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add environment variable to control IO capture in
@observedecorator, improving performance for large objects.LANGFUSE_OBSERVE_DECORATOR_IO_CAPTURE_ENABLEDtoenvironment_variables.pyto control IO capture in@observedecorator.True, allowing automatic capture of function args, kwargs, and return values.LangfuseDecorator.observe()inobserve.pyto checkLANGFUSE_OBSERVE_DECORATOR_IO_CAPTURE_ENABLED.capture_inputandcapture_output) is conditional on the environment variable beingTrue.This description was created by
for a9cc9f1. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Added environment variable
LANGFUSE_OBSERVE_DECORATOR_IO_CAPTURE_ENABLEDto control automatic function input/output capture in the@observedecorator, helping optimize performance when dealing with large objects.langfuse/_client/environment_variables.pywith clear documentation about performance implicationslangfuse/_client/observe.pyto respect the environment variable setting when determining if IO capture should be enabledTrueand combines with per-function capture flags using logical AND